fix: relax json pin restriction to minor, not patch revision#138
Merged
Conversation
Member
Author
|
Hey @bryan-ash, let me check up on it. Hey @impurist - Could you cast your eyes on this please, if your happy, I'll cut a release. |
Member
Author
|
Now removing the introduced json dep from #118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @impurist,
This following commit pins json to a json's patch version, could we relax it to patch so that we can use the latest json gem in the pact-docker-cli
6da53f5
pact-docker-cli fails to update, as it requires
-> 2.18https://github.com/pact-foundation/pact-docker-cli/actions/runs/20855919023/job/59922394460
Thank you!
PS. the restriction is too strict for pact-standalone, which currently uses standard gems from ruby 3.3.9. of which json is 2.7.2, that can be resolved, by using native extensions which I've recently built for all platforms (windows support is new), which is why previously we had to pin to std gems to avoid building native extensions